-
Notifications
You must be signed in to change notification settings - Fork 103
Experimental CI entry to run tests with latest dependencies #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jun 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach of only using one permutation to do this here. Added slight suggestion.
cretz
approved these changes
Jun 25, 2025
dandavison
approved these changes
Jun 25, 2025
cretz
reviewed
Jun 27, 2025
cretz
approved these changes
Jun 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(re-approving to confirm my approval still stands)
tconley1428
added a commit
that referenced
this pull request
Jun 30, 2025
* Experimental CI entry to run tests with latest dependencies * Fix upgrade command * Further discriminate log names * Remove locked from matrix * Fixing problem with updated openai dependency * Lint * Move latest deps test to separate job * Fix openai test break * Pydantic validation fails anyway, so remove type ingore * CI cleanup
tconley1428
added a commit
that referenced
this pull request
Jul 1, 2025
* Adding replay and end to end tests for all existing tests * Experimental CI entry to run tests with latest dependencies (#920) * Experimental CI entry to run tests with latest dependencies * Fix upgrade command * Further discriminate log names * Remove locked from matrix * Fixing problem with updated openai dependency * Lint * Move latest deps test to separate job * Fix openai test break * Pydantic validation fails anyway, so remove type ingore * CI cleanup * Remove history write * Linting * Remove history output * Configure the data converter * Linting * Fix merge error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a new CI run which upgrades dependencies prior to testing
Why?
This will help us validate that things work the way users will use them, with the most up to date dependencies, rather than the locked ones we use for development.
Checklist
Closes
How was this tested:
New CI
Any docs updates needed?